mORMot Open Source

itSDS

Member

From: Germany

Registered: 2014-04-24

Posts: 551

BUGFix for mORMot.pas

Hi Arnaud. i tried to upload this patch to github. But my credentials are rejected

diff --git a/SQLite3/mORMot.pas b/SQLite3/mORMot.pas
index 5b692f78..30d00b67 100644
--- a/SQLite3/mORMot.pas
+++ b/SQLite3/mORMot.pas
@@ -58447,10 +58447,11 @@ begin
   else
     result := fImplementationClass.Create;
   end;
+  inc(TInterfacedObjectHooked(result).FRefCount); // >0 to call Support() in event
   if Assigned(TSQLRestServer(Rest).OnServiceCreateInstance) then
     TSQLRestServer(Rest).OnServiceCreateInstance(self,result);
-  if AndIncreaseRefCount then
-    IInterface(result)._AddRef; // allow passing self to sub-methods
+  if not AndIncreaseRefCount then
+    dec(TInterfacedObjectHooked(result).FRefCount);
 end;
 
 procedure TServiceFactoryServer.OnLogRestExecuteMethod(Sender: TServiceMethodExecute;

---

Rad Studio 12.3 Athens

sakura

Member

From: Germany

Registered: 2018-02-21

Posts: 240

Website

Re: BUGFix for mORMot.pas

Hi,

you need your own github account, clone the repo to your account, upload the changes to yours and then start a pull-request. This way, a review before merge is possible.

Regards,
Daniel

ab

Administrator

From: France

Registered: 2010-06-21

Posts: 15,007

Website

Re: BUGFix for mORMot.pas

I have seen you backported TServiceFactoryServer.CreateInstance refcount logic from mORMot 2.

I have pushed the modification.
See https://synopse.info/fossil/info/215152b939

itSDS

Member

From: Germany

Registered: 2014-04-24

Posts: 551

Re: BUGFix for mORMot.pas

thank you - yes i used a piece of code with mORMot2 and then with mORMot and under mORMot my Objekt was freed in Support...

---

Rad Studio 12.3 Athens